Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update okhttp client version from 3.6.0 to 3.14.4. #1158

Merged
merged 2 commits into from Jan 17, 2020
Merged

Update okhttp client version from 3.6.0 to 3.14.4. #1158

merged 2 commits into from Jan 17, 2020

Conversation

svenhaag
Copy link
Contributor

PR for #1153

Updating only the okhttp client version, not the mockwebserver version.

@kdavisk6
Copy link
Member

@svenhaag

I looks like the pom file contains CLRF values. Can you please update this PR normalizing the line endings to LF?

@kdavisk6 kdavisk6 added the feedback provided Feedback has been provided to the author label Jan 14, 2020
@svenhaag
Copy link
Contributor Author

@svenhaag

I looks like the pom file contains CLRF values. Can you please update this PR normalizing the line endings to LF?

Line endings seem all fine to me (checked in repo dierctly). However I had a tab instead of spaces in front of mockserver version line. Could this the build causing to fail?

@kdavisk6
Copy link
Member

Yeah, seems so.

@kdavisk6 kdavisk6 added ready to merge Will be merged if no other member ask for changes and removed feedback provided Feedback has been provided to the author labels Jan 17, 2020
@velo velo merged commit 49e1373 into OpenFeign:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Will be merged if no other member ask for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants