Restore Request.Body accessibility for compatibility #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes OpenFeign#1163 Restores `Request.Body.encoded` static function and `RequestTemplate.requestBody` to restore compatibility. Additionally, mark it as deprecated to encourage usage of `RequestTemplate.body`. `Request.Body` is an internal abstraction that was made built in an effort to better manage request body data. It was made public too early and will be reverted back to it's internal state in future releases.
kdavisk6
added
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1163
Restores
Request.Body.encodedstatic function andRequestTemplate.requestBodyto restore compatibility.Additionally, mark it as deprecated to encourage usage of
RequestTemplate.body.Request.Bodyis an internal abstraction that was made builtin an effort to better manage request body data. It was made
public too early and will be reverted back to it's internal
state in future releases.