Metric API #1181
Merged
Metric API #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdavisk6
reviewed
Feb 28, 2020
| </parent> | ||
| <artifactId>feign-metrics5</artifactId> | ||
| <name>Feign Metrics5</name> | ||
| <description>Feign Dropwizard Metrics 5</description> |
There was a problem hiding this comment.
I'd like to suggest an alternative, Micrometer. It can wrap Dropwizard and will allow this to be integrated directly into Spring Boot/Cloud, since Micrometer is their preferred metrics collector.
There was a problem hiding this comment.
My plan is to add that one later, added metrics 5 first cause is the one I'm using and gets values for me faster
There was a problem hiding this comment.
They both do the same thing. If you want to have multiple implementations I’d like to suggest that we rename this to metrics-dropwizard
kdavisk6
added
enhancement
velo
added
ready to merge
kdavisk6
approved these changes
Mar 6, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a first-class Metrics API that users can tap into to gain insight into the request/response lifecycle.
My plan is:
Extend the capabilities to Async and Reactive (before 10.8 release)
Add metrics support for OpenTracing
After this, I feel we are in a good place to cut 10.8 and being 11 branch