Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overriding query parameter name #1184

Merged
merged 2 commits into from Mar 9, 2020
Merged

Overriding query parameter name #1184

merged 2 commits into from Mar 9, 2020

Conversation

boggard
Copy link
Contributor

@boggard boggard commented Mar 6, 2020 •
edited

Relates to #1183

@boggard boggard changed the title Overriding query parameter name #1183 Overriding query parameter name Mar 6, 2020
velo
velo reviewed Mar 6, 2020
View reviewed changes
Copy link
Member

@velo velo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, build is failing though.

I would probably chance to use existing Param annotation, unless a strong reason not to. Other then that, all good.

core/src/main/java/feign/ParamAlias.java Outdated Show resolved Hide resolved
@kdavisk6 kdavisk6 added the feedback provided Feedback has been provided to the author label Mar 6, 2020
@kdavisk6
Copy link
Member

kdavisk6 commented Mar 6, 2020

Please add a description referencing the issue this PR is for.

kdavisk6
kdavisk6 requested changes Mar 6, 2020
View reviewed changes
Copy link
Member

@kdavisk6 kdavisk6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See our previous comments.

@boggard
Copy link
Contributor Author

boggard commented Mar 8, 2020

I used @Param following the comments above. Do i need to use Param.Expander for parameter value, when @Param used?

@boggard boggard requested a review from kdavisk6 March 8, 2020 13:42
velo
velo approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@velo velo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@velo velo mentioned this pull request Mar 9, 2020
Closed
@velo velo merged commit 68f7984 into OpenFeign:master Mar 9, 2020
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velo velo velo approved these changes

@kdavisk6 kdavisk6 Awaiting requested review from kdavisk6

Assignees
No one assigned
Labels
feedback provided Feedback has been provided to the author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boggard @kdavisk6 @velo