GH-1172: Store expanded Header Template values as Literals #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes OpenFeign#1172 When a `HeaderTemplate` is expanded, the result is placed onto a new `RequestTemplate` via it's `header` method. This results in the expanded result being turned back into a `HeaderTemplate`, simply out of convenience. This behavior, while fine more general use cases, is problematic if the header value contains braces `{` `}`, as this will cause the app to consider these values as new expressions. At this point in the expansion process, there is no need to evaluate the expanded values again, so this change allows a `Template` to be created from an existing List of `TemplateChunks`, allowing for callers to provide explicit `Literal` or `Expression` chunks directly into a `Template`, by passing the template parsing algorithms. `RequestTemplate#expand` has been updated to apply this logic for `HeaderTemplate` values only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1172
When a
HeaderTemplateis expanded, the result is placed onto a newRequestTemplatevia it'sheadermethod. This results in the expandedresult being turned back into a
HeaderTemplate, simply out ofconvenience. This behavior, while fine more general use cases, is
problematic if the header value contains braces
{}, as this willcause the app to consider these values as new expressions.
At this point in the expansion process, there is no need to evaluate
the expanded values again, so this change allows a
Templateto becreated from an existing List of
TemplateChunks, allowing for callersto provide explicit
LiteralorExpressionchunks directly into aTemplate, by passing the template parsing algorithms.RequestTemplate#expandhas been updated to apply this logic forHeaderTemplatevalues only.