Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java11client connect timeout #1307

Merged
merged 3 commits into from Dec 23, 2020

Conversation

gb-klein
Copy link
Contributor

Java11 client (feign.http2client.Http2Client) should consider Options::connectTimeoutMillis

Problem: Http2Client does not consider connectTimeoutMillis from Options (and followRedirects as well).
Solution:

  • on request execution check if the provided Options differ from the current client's timeout and redirect settings. If yes => create a new client from the existing one, but with timeout and redirect settings from Options.
  • Additionally provide a constructor taking Options. This will decrease the probability of client configuration mismatches and thus increase performance

fixes #1306

Copy link
Member

@kdavisk6 kdavisk6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this one.

@kdavisk6 kdavisk6 added feedback provided Feedback has been provided to the author ready to merge Will be merged if no other member ask for changes labels Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback provided Feedback has been provided to the author ready to merge Will be merged if no other member ask for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java11 client should consider Options::connectTimeoutMillis
2 participants