Allows @Param value in default contract to be taken from param names. #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzyk
force-pushed
the
friendly-params
branch
2 times, most recently
from
57afd73
to
4c2a14b
Compare
kdavisk6
requested changes
Nov 22, 2020
kdavisk6
added
documentation
JEP 118 introduced javac option `-parameters` that adds to bytecode method parameter names, so if code is compiled with that option and @param value is empty we can get that template parameter name from method parameter name. Fixes OpenFeign#1297.
krzyk
force-pushed
the
friendly-params
branch
from
4c2a14b
to
fd7ab31
Compare
|
@kdavisk6 I've updated the README.md |
kdavisk6
approved these changes
Nov 24, 2020
kdavisk6
added
the
ready to merge
|
@kdavisk6 Can this be merged? Builds are passing and I would like to use it in my project |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JEP 118 introduced javac option
-parametersthat adds to bytecodemethod parameter names, so if code is compiled with that option
and @param value is empty we can get that template parameter name
from method parameter name.
Fixes #1297.