Support metric names customization #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuvaldis
force-pushed
the
micrometer-custom-metric-names
branch
from
c195b9c
to
71be494
Compare
kdavisk6
added
feedback provided
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's not possible to use custom names for micrometer metrics without having to almost completely reimplement existing Feign Micrometer classes.
Different clients (e.g. Spring WebClient) may define different names like
http.client.request. Same name can be used for Feign Clients.Intention is to allow developers to define their own implementations of
MetricNameforMeteredClientand other related classes.Fixes #1300