Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK 11 HttpClient async implement for AsyncFeign. #1330

Merged
merged 23 commits into from Oct 17, 2021
Merged

JDK 11 HttpClient async implement for AsyncFeign. #1330

merged 23 commits into from Oct 17, 2021

Conversation

xrayw
Copy link
Contributor

@xrayw xrayw commented Dec 19, 2020 •
edited

The test case i was copy from AsyncApacheHttp5ClientTest and some code was changed ..

thanks.

@xrayw
Copy link
Contributor Author

xrayw commented Dec 22, 2020

I run mvn clean install on my local, but no issue found, so what's about the continuous error??

@kdavisk6
Copy link
Member

@UzimakiNaruto Looks like you have some formatting issues. Please run ./mvnw install locally to format the files then rebase this branch against the most recent master. Once the checks are green, we'll review.

@kdavisk6 kdavisk6 added the waiting for feedback Issues waiting for a response from either to the author or other maintainers label Dec 29, 2020
@xrayw
Copy link
Contributor Author

xrayw commented Dec 30, 2020

@kdavisk6 Hi, I fixed the format. the check looks fine now. Thanks.

@velo velo requested a review from kdavisk6 July 23, 2021 02:51
@velo velo added the ready to merge Will be merged if no other member ask for changes label Jul 23, 2021
@velo velo merged commit b06f47a into OpenFeign:master Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velo velo velo approved these changes

@kdavisk6 kdavisk6 Awaiting requested review from kdavisk6

Assignees
No one assigned
Labels
ready to merge Will be merged if no other member ask for changes waiting for feedback Issues waiting for a response from either to the author or other maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrayw @kdavisk6 @velo