Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for FeignException cannot get the correct charset (#1325) #1345

Merged
merged 18 commits into from Mar 7, 2021

Conversation

Linda-pan
Copy link
Contributor

Fix bug for FeignException cannot get the correct charset(#1325)

Copy link
Member

@kdavisk6 kdavisk6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Linda-pan Please add a unit test for this use case.

@kdavisk6 kdavisk6 added the feedback provided Feedback has been provided to the author label Dec 29, 2020
@kdavisk6
Copy link
Member

@Linda-pan Your latest changes are not formatted correctly, please fun mvn install locally to format the files, commit the changes and push the updates to fix the build

Copy link
Contributor Author

@Linda-pan Linda-pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix bug for FeignException cannot get the correct charset and add some tests

@kdavisk6 kdavisk6 added ready to merge Will be merged if no other member ask for changes and removed feedback provided Feedback has been provided to the author labels Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Will be merged if no other member ask for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants