GH-1270: Fix conflict between single and multi-value headers #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: OpenFeign#1270 `HeaderTemplate` was confusing iterable values with literal values due to the presence of comma `,` characters in the result. The result was that, in certain cases like HTTP Dates, additional spaces were inserted into the final expanded value. The root cause of the issue is that `HeaderTemplate` combined all values into a single `String` template, with each value separated by a comma. This change refactors `HeaderTemplate` to treat all `values` as individual `Templates`, removing the need to combine any provided values into a single String.
This was referenced Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1270
HeaderTemplatewas confusing iterable values with literal values dueto the presence of comma
,characters in the result. The result wasthat, in certain cases like HTTP Dates, additional spaces were inserted
into the final expanded value.
The root cause of the issue is that
HeaderTemplatecombined all valuesinto a single
Stringtemplate, with each value separated by a comma.This change refactors
HeaderTemplateto treat allvaluesas individualTemplates, removing the need to combine any provided values into a singleString.