Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade httpclient5 to GA version 5.0.3 #1373

Merged
merged 3 commits into from Mar 7, 2021
Merged

Upgrade httpclient5 to GA version 5.0.3 #1373

merged 3 commits into from Mar 7, 2021

Conversation

thanhj
Copy link
Contributor

@thanhj thanhj commented Mar 5, 2021

No description provided.

@thanhj
Copy link
Contributor Author

thanhj commented Mar 5, 2021

Im not sure why all checks failed, my changes don't seem relevant.

@kdavisk6
Copy link
Member

kdavisk6 commented Mar 7, 2021

Files you changed do not have the right license header. Run ./mvnw license:format and commit the updated file headers.

@kdavisk6 kdavisk6 added the feedback provided Feedback has been provided to the author label Mar 7, 2021
@kdavisk6 kdavisk6 added ready to merge Will be merged if no other member ask for changes and removed feedback provided Feedback has been provided to the author labels Mar 7, 2021
@kdavisk6
Copy link
Member

kdavisk6 commented Mar 7, 2021

@thanhj I corrected the headers and updated this for you.

@kdavisk6 kdavisk6 merged commit c4b89c2 into OpenFeign:master Mar 7, 2021
@thanhj
Copy link
Contributor Author

thanhj commented Mar 7, 2021

Thanks! @kdavisk6

@thanhj
Copy link
Contributor Author

thanhj commented Mar 7, 2021

@kdavisk6, by the way, when is the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Will be merged if no other member ask for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants