Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSON-java decoder and encoder #1387

Merged
merged 10 commits into from Jun 30, 2021
Merged

Add JSON-java decoder and encoder #1387

merged 10 commits into from Jun 30, 2021

Conversation

vitalijr2
Copy link
Collaborator

Added module for encoding and decoding using JSON-java.

Implements #1385

velo
velo requested changes Apr 22, 2021
View reviewed changes
Copy link
Member

@velo velo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @radio-rogal , I asked for a few changes, lemme know how it goes.

json/README.md Outdated Show resolved Hide resolved
json/pom.xml Show resolved Hide resolved
json/src/main/java/feign/json/JsonEncoder.java Outdated Show resolved Hide resolved
json/src/main/java/feign/json/JsonEncoder.java Outdated Show resolved Hide resolved
json/src/main/java/feign/json/JsonDecoder.java Outdated Show resolved Hide resolved
@velo velo added enhancement For recommending new capabilities feedback provided Feedback has been provided to the author waiting for votes Enhancements or changes proposed that need more support before consideration labels Apr 22, 2021
@vitalijr2
Rename feign-json to feign-org.json, add link to JSON web-site to REA…
1984dcc 
…DME, use instanceof instead of references (JsonEncoder)
@vitalijr2
Copy link
Collaborator Author

@velo done

@velo velo added ready to merge Will be merged if no other member ask for changes and removed feedback provided Feedback has been provided to the author waiting for votes Enhancements or changes proposed that need more support before consideration labels Jun 30, 2021
@velo velo merged commit 5087bd8 into OpenFeign:master Jun 30, 2021
@vitalijr2 vitalijr2 deleted the feature/feign-json branch July 1, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velo velo velo approved these changes

@kdavisk6 kdavisk6 kdavisk6 approved these changes

Assignees
No one assigned
Labels
enhancement For recommending new capabilities ready to merge Will be merged if no other member ask for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vitalijr2 @velo @kdavisk6