Modify DefaultMethodHandler to work with Android #1436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 28 (Android 8) however, Android 9+ enforces more strict checking with reflection. Solution is to use double reflection, as below. Jamie (xrpdevs-at-xrpdevs-co-uk) TODO: Integrate back into version forked from, keep original legacyReadLookup and safeReadLookup and add conditional branch if running on Dalvik (android java runtime)
Previous commit did not deal with Android 9+ reflection security. Solution in Android 9 is to use double reflection. Android's JVM is detected at runtime and MethodHandle is obtained in an Android compatible way, otherwise, we run readLookup() instead.
velo
requested changes
Jun 13, 2021
xrpdevs
commented
Jun 15, 2021
| if (System.getProperty("java.vm.name").equalsIgnoreCase("Dalvik")) { | ||
| return androidLookup(declaringClass); | ||
| } else { | ||
| return safeReadLookup(declaringClass); |
There was a problem hiding this comment.
I had "readLookup" instead of "safeReadLookup" here. Building now...
|
For some unknow reason, this is not building at all: @kdavisk6 any clue? |
|
Buiding locally for me without issue (IDEA/Maven) and passing CircleCi tests.
I did read this regarding merges being blocked due to how CircleCI is configured:
https://circleci.com/docs/2.0/workflows/#workflows-waiting-for-status-in-github
Marvin Froeder ***@***.***> wrote ..
… For some unknow reason, this is not building at all:
<img width="973" alt="Screen Shot 2021-06-16 at 15 22 56" src="https://user-images.githubusercontent.com/136590/122153278-28146f00-ce52-11eb-8ac2-492a74f39f88.png">
@kdavisk6 any clue?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#1436 (comment)
|
Closed
…g back to legacy if all else fails. Interestingly, the methods I created for Android seem to work just fine in "vanilla" Java.
velo
added a commit
that referenced
this pull request
Jun 16, 2021
* Modify DefaultMethodHandler to work with Android. * Modified to work with Android. Previous commit worked up to API level 28 (Android 8) however, Android 9+ enforces more strict checking with reflection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting errors regarding illegal reflective access here, and also another one saying IMPL_LOOKUP was not defined, depending on the Android version I was running on.
These changes should work across the board, Android or actual JRE's.
A very frustrating way for someone inexperienced with reflection to spend a day :/
HTH someone!