Fix exception thrown when using a custom error decoder with metrics #1468

DarkAtra · 2021-07-26T15:48:46Z

…hen using custom ErrorDecoder

velo · 2021-07-26T22:31:53Z

micrometer/src/main/java/feign/micrometer/MeteredInvocationHandleFactory.java

-        } catch (Exception e) {
-          throw e;
-        } catch (Throwable e) {
-          throw new Exception(e);


I saw no reason to have this layer of try catches... removed

DarkAtra and others added 3 commits July 26, 2021 17:46

#1466: fixed metered feign client throwing IllegalArgumentException w…

54bca4e

…hen using custom ErrorDecoder

#1466: add missing license header

703b512

Fold MeteredFeignClientTest into AbstractMetricsTestBase

fa1ff28

velo reviewed Jul 26, 2021

View reviewed changes

velo approved these changes Jul 26, 2021

View reviewed changes

velo merged commit 7861fbc into OpenFeign:master Jul 26, 2021

Provide feedback