Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible to customize the length of the body in FeignException? #1606

Closed
jiahui-qin opened this issue Apr 7, 2022 · 3 comments
Closed

Is it possible to customize the length of the body in FeignException? #1606

jiahui-qin opened this issue Apr 7, 2022 · 3 comments
Labels
help wanted Issues we need help with tackling proposal Proposed Specification or API change

Comments

@jiahui-qin
Copy link

feign in master branch

I found that FeignException enforces the length of body not to exceed 400, use below two param:

    private static final int MAX_BODY_BYTES_LENGTH = 400;
    private static final int MAX_BODY_CHARS_LENGTH = 200;

Is there a way I can customize the length of these two variables to get more error messages?

Thank you!
@prashanth057
Copy link

prashanth057 commented Aug 1, 2022 •
edited

I need this too. Any way to bump up the priority on this?

@velo
Copy link
Member

velo commented Aug 1, 2022

Hi @prashanth057 , feign is mainly run by volunteers. Either you need to get a volunteer interested to do it for you, or you file a PR for this and I will happily review it.

coungard added a commit to coungard/feign that referenced this issue Sep 23, 2022
@coungard
Issue OpenFeign#1606 Customize the length of the body in FeignExcepti…
ab4836c 
…on builder
@coungard coungard mentioned this issue Sep 26, 2022
Merged
coungard added a commit to coungard/feign that referenced this issue Sep 27, 2022
@coungard
Issue OpenFeign#1606 Customize the length of the body in FeignExcepti…
733029b 
…on builder
@kdavisk6 kdavisk6 added help wanted Issues we need help with tackling proposal Proposed Specification or API change labels Oct 7, 2022
velo added a commit that referenced this issue Oct 9, 2022
@coungard @vitalijr2 @velo
Issue #1606 Customize the length of the body in FeignException builder (
caa3064 
#1767)

Co-authored-by: Witalij Berdinskich <radio_rogal@keemail.me>
Co-authored-by: Marvin Froeder <velo@users.noreply.github.com>
@ddeath
Copy link
Contributor

ddeath commented Jul 4, 2023

This can be closed as the proposal was merged right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issues we need help with tackling proposal Proposed Specification or API change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@velo @ddeath @kdavisk6 @prashanth057 @jiahui-qin