Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s-wait-for image is inactively maintained and contains many vulnerabilities #132

Open
rorynickolls-skyral opened this issue May 8, 2024 · 2 comments

Comments

@rorynickolls-skyral
Copy link
Contributor

The k8s-wait-for image has had no merged PRs for 2 years and contains many unaddressed vulnerabilities in its latest v2.0 release: groundnuty/k8s-wait-for#71.

A previous PR to address this received no attention and was closed: groundnuty/k8s-wait-for#65

Is this image strictly necessary or are there alternatives that could be used?

@jon-whit
Copy link
Member

jon-whit commented May 8, 2024

@rorynickolls-skyral without introducing anything more than an image or standard Helm or Kubernetes tooling, are you aware of other mechanisms to wait for a Kubernetes job to complete? That's the only reason we have k8s-wait-for. If we can achieve that same objective in other ways then we can drop it.

kubectl wait --for=condition=complete job/myjob

☝️ May be a good alternative. We could use the bitnami/kubectl image.

@rorynickolls-skyral
Copy link
Contributor Author

I can see you have chart hooks already. I'm guessing the difficulty here is that the job always needs to come after OpenFGA spins up to put it on the latest schema? So a pre-upgrade hook won't work.

I think your suggestion would work nicely -- the image still has quite a few vulns but is better maintained so no doubt they will be fixed.

You may even get away with hitting the k8s REST API with curl and your service account credentials. A less maintainable and more complex option than your suggestion though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants