Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSL Condition Support: Known Issues #96

Open
2 of 6 tasks
rhamzeh opened this issue Nov 3, 2023 · 0 comments
Open
2 of 6 tasks

DSL Condition Support: Known Issues #96

rhamzeh opened this issue Nov 3, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@rhamzeh
Copy link
Member

rhamzeh commented Nov 3, 2023 •
edited

The following are the known issues for the current WIP support for conditions in language:

Validation in JS

(Note language does not yet do validations in Go)

  • Condition CEL Expression is not validated
  • Condition Parameters are not validated to be used and usable in the expression
  • Condition CEL Expression is not validated to be not using undefined parameters

Parsing

  • Some valid CEL expressions are not parsed properly
  • } cannot occur in the expression
  • Relation, parameter or type names that conflict with parameter type keywords (map, list, string, etc..) are parsed incorrectly
@rhamzeh rhamzeh added the bug Something isn't working label Nov 3, 2023
@rhamzeh rhamzeh self-assigned this Nov 3, 2023
@rhamzeh rhamzeh removed their assignment Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhamzeh