You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
is highly complex and require refactoring. The PR slight reduces complexity. However, we require more systematic approach to make the server config better
The text was updated successfully, but these errors were encountered:
Hi @adriantam ,
as the merge was messy to compare/fix, I've reset local branch to match upstream/main and will re-submit the changes for review. This caused the PR #1605 to get closed. Can you please re-open it for me.
My plan is to:
reopen in draft mode and review 2 out of the 4 func refactors in run.go file
if ok, proceed to the last two refactors
move from draft to formal PR review
The stepped approach is
a) reduce lines to review per iteration
b) avoid (or minimize) dealing with conflicts during merges with upstream
As per #1552 (comment), the function ServerContext Run()
openfga/cmd/run/run.go
Line 279 in abf5664
The text was updated successfully, but these errors were encountered: