Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"datastore.uri" and "datastore.engine" should be required fields when doing run and migrate #681

Open
miparnisari opened this issue Apr 6, 2023 · 2 comments · May be fixed by #810
Open

"datastore.uri" and "datastore.engine" should be required fields when doing run and migrate #681

miparnisari opened this issue Apr 6, 2023 · 2 comments · May be fixed by #810
Labels
enhancement New feature or request

Comments

@miparnisari
Copy link
Member

miparnisari commented Apr 6, 2023 •
edited

  • If uri is not empty but engine is, we should error out.
  • If engine is set to be Postgres or Mysql and uri is empty, we should error out.
image image
@miparnisari miparnisari added the enhancement New feature or request label Apr 18, 2023
@Himanshu372 Himanshu372 mentioned this issue Apr 22, 2023
Closed
4 tasks
@Himanshu372
Copy link

Have a PR in draft for the above - #712

@jon-whit
Copy link
Member

jon-whit commented Nov 6, 2023

#810 supersedes #712

@miparnisari miparnisari linked a pull request Apr 17, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate datastore engine Himanshu372/openfga
3 participants
@jon-whit @miparnisari @Himanshu372