Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java SDK - Allow Configuration override per request #175

Open
booniepepper opened this issue Aug 16, 2023 · 1 comment
Open

Java SDK - Allow Configuration override per request #175

booniepepper opened this issue Aug 16, 2023 · 1 comment
Assignees
@booniepepper
Labels
java-sdk Affects the Java/Kotlin SDK

Comments

@booniepepper
Copy link
Contributor

For each request, allow a BaseConfiguration to be added as a parameter. When added, they should be used instead of values from Configuration it was initialized with

Reminder: Call assertValid()
@booniepepper booniepepper mentioned this issue Aug 21, 2023
Merged
4 tasks
@booniepepper booniepepper self-assigned this Aug 22, 2023
@booniepepper
Copy link
Contributor Author

booniepepper commented Aug 24, 2023 •
edited

Implemented here: #189

As noted in comments, some test cases (config overridden requests) haven't been written yet. The most critical parts of the code (Configuration.override(...)) are sufficiently covered

@rhamzeh rhamzeh added the java-sdk Affects the Java/Kotlin SDK label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@booniepepper booniepepper

Labels
java-sdk Affects the Java/Kotlin SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhamzeh @booniepepper