Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[All SDKs] Remove ReadAuthorizationModel call in BatchCheck #314

Open
4 of 5 tasks
rhamzeh opened this issue Feb 23, 2024 · 2 comments
Open
4 of 5 tasks

[All SDKs] Remove ReadAuthorizationModel call in BatchCheck #314

rhamzeh opened this issue Feb 23, 2024 · 2 comments
Assignees
@evansims
Labels
dotnet-sdk Affects the C#/DotNet SDK go-sdk Affects the Go SDK java-sdk Affects the Java/Kotlin SDK js-sdk Affects the JavaScript SDK python-sdk Affects the Python SDK

Comments

@rhamzeh
Copy link
Member

rhamzeh commented Feb 23, 2024 •
edited

Some (not all) SDKs call ReadAuthorizationModel, before checks in BatchCheck.

We need to remove that and replace that with better error handling where we exit early in cases of 401s instead of repeatedly calling check unnecessarily
@rhamzeh rhamzeh added go-sdk Affects the Go SDK dotnet-sdk Affects the C#/DotNet SDK js-sdk Affects the JavaScript SDK python-sdk Affects the Python SDK java-sdk Affects the Java/Kotlin SDK labels Feb 23, 2024
@aaguiarz
Copy link
Member

Please let's start by addressing it in the Javascript SDK

@rhamzeh rhamzeh mentioned this issue Feb 26, 2024
Merged
4 tasks
@ewanharris ewanharris mentioned this issue Feb 26, 2024
Merged
4 tasks
@evansims evansims self-assigned this Mar 1, 2024
@ewanharris
Copy link
Member

ewanharris commented May 1, 2024 •
edited

Closing as all SDKs no longer call this or never did

Reopening as python still needs to be done

@ewanharris ewanharris reopened this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evansims evansims

Labels
dotnet-sdk Affects the C#/DotNet SDK go-sdk Affects the Go SDK java-sdk Affects the Java/Kotlin SDK js-sdk Affects the JavaScript SDK python-sdk Affects the Python SDK
Projects
SDKs and Tooling
Status: Ready
Milestone
No milestone
Development

No branches or pull requests
4 participants
@evansims @rhamzeh @aaguiarz @ewanharris