Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUU] Change unit scale #12005

Open
mariocarabotta opened this issue Jan 4, 2024 · 8 comments · May be fixed by #12183
Open

[BUU] Change unit scale #12005

mariocarabotta opened this issue Jan 4, 2024 · 8 comments · May be fixed by #12183
Assignees

Comments

@mariocarabotta
Copy link
Collaborator

mariocarabotta commented Jan 4, 2024

  • picker with no search
  • if Item is selected, show mandatory text field (David to check)
    Screenshot 2024-02-29 at 2 47 25 pm
  • if clicking outside without filling text field, display default browser inline error and don't close dropdown

Image

  • if Item is selected and text field filled, once clicking out of the dropdown, show Item (text field) in the column
    Screenshot 2024-02-29 at 2 51 13 pm

Preview: https://www.figma.com/proto/ddL6h7H9It5ZmUuVYQxzAD/Product-List?page-id=874%3A30&type=design&node-id=874-31&viewport=805%2C358%2C0.26&t=6jfW8boLyZ0pNeKn-1&scaling=min-zoom&starting-point-node-id=874%3A31

Planning ahead for product refactor, the unit scale will have a separate column so that it can sit side-by-side with unit value: https://www.figma.com/proto/ddL6h7H9It5ZmUuVYQxzAD/Product-List?page-id=931%3A30&type=design&node-id=931-1313&viewport=522%2C320%2C0.63&t=HwNQ68IeImrftI4L-1&scaling=min-zoom

@mariocarabotta mariocarabotta added the design-needed issues requiring design label Jan 4, 2024
@dacook
Copy link
Member

dacook commented Jan 9, 2024

Tom-select already has options for inputting new values, so that should be possible. Examples: https://tom-select.js.org/examples/

@mariocarabotta mariocarabotta changed the title [BUU] Change unit type [BUU] Change unit scale Feb 20, 2024
@mariocarabotta mariocarabotta changed the title [BUU] Change unit scale [BUU] Change unit scale Feb 20, 2024
@mariocarabotta
Copy link
Collaborator Author

Estimate: 2 days

@dacook dacook self-assigned this Feb 20, 2024
@dacook dacook linked a pull request Feb 21, 2024 that will close this issue
4 tasks
@dacook

This comment was marked as off-topic.

@mariocarabotta mariocarabotta removed the design-needed issues requiring design label Feb 27, 2024
@dacook
Copy link
Member

dacook commented Mar 5, 2024

I just caught up with @itsamemario, and confirmed that I’m not able to implement the designed component unfortunately. Maybe there is a way, but it would require sinking more of my or someone else’s time into it without a guaranteed result.

We discussed an alternative design which seems like a reasonable alternative (working around the dropdown component, rather than trying to customise it).

But as it would still require more development time, we’ll first just implement the same as the current screen, which should require very little dev time. Then we can continue working on feature parity before revisiting this later.

@dacook
Copy link
Member

dacook commented Mar 5, 2024

Alternative solution: popout when "items" selected

  • When a weight or volume is selected, it just appears and functions exactly like a dropdown
  • When "items" selected, the popout appears, revealing and focusing the label text field (required field).
  • When click or tab away, the popout closes and it appears like a normal field, with combined label "Items ()"
  • When activating again, the popout shows and you can either open the dropdown or edit the label
  • If a weight or volume is selected, the dropdown and popout close.

@dacook
Copy link
Member

dacook commented Mar 13, 2024

Confirming that we've reached feature parity, with an input field that appears when you choose "items", just like in the old screen.
Screenshot 2024-03-06 at 1 52 19 pm

But we would like to continue with a better (more compact) solution, as designed (see description at top) or with an alternative (like mine suggested in comment above)

@kirstenalarsen
Copy link
Contributor

OK so @dacook @mariocarabotta for our 'now' purposes, this is done, so I'm putting it back in 'All the Things'

@RachL
Copy link
Contributor

RachL commented Mar 13, 2024

@kirstenalarsen actually now with the new board, "all the things" is our backlog. I'm changing the milestone 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: All the things 💤
Development

Successfully merging a pull request may close this issue.

4 participants