Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused Discourse SSO integration #12355

Closed
dacook opened this issue Apr 10, 2024 · 1 comment · Fixed by #12496
Closed

Remove unused Discourse SSO integration #12355

dacook opened this issue Apr 10, 2024 · 1 comment · Fixed by #12496
Labels
tech debt

Comments

@dacook
Copy link
Member

dacook commented Apr 10, 2024

What we should change and why (this is tech debt)

There is some code for linking up with a discourse instance. But it is:

eight years old. I think it was used with the Fair Food Forum which is now not used anymore. So we can take it out.

See lib/discourse/single_sign_on.rb and any other related files, environment variables etc. There are mentions in:

Context

Discussed in #delivery-circle

Impact and timeline
@dacook dacook mentioned this issue Apr 10, 2024
Open
@isidzukuri isidzukuri mentioned this issue May 18, 2024
Merged
4 tasks
@isidzukuri
Copy link
Contributor

@dacook please take a look #12496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
OFN Delivery board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[12355] Remove discourse isidzukuri/openfoodnetwork
2 participants
@dacook @isidzukuri