-
-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Admin->Orders] Include tax on fees in the line item adjustment table #11680
Comments
@mkllnk we need your view on that one: do you think it could be done as a papercut? |
Yes, it probably needs an hour or two to understand the data structure and to find the best solution but then it should easy to change. We currently just list adjustment associated to line items but we need to add the adjustments of those adjustments as well. Just go a level deeper. I think that we need to change this line:
We can add a helper like the one for order adjustments: openfoodnetwork/app/helpers/admin/orders_helper.rb Lines 5 to 11 in 7ef4df0
It needs to add the tax adjustments to the current list. |
@dacook please assign to me, id like to work on this |
Hello @abdulazizali77 I hope this message finds you well; I'm only checking in, no pressure: are you still working on this issue? |
@RachL sorry for delay ill put a PR next week! |
…e fee and calculator factory openfoodfoundation#11680
…e fee and calculator factory openfoodfoundation#11680
Add new text key admin.order.edit.additional_tax_included_in_price Add spec file for additional tax display. Add new trait for enterprise fee and calculator factory
Add new text key admin.order.edit.additional_tax_included_in_price Add spec file for additional tax display. Add new trait for enterprise fee and calculator factory
Description
- As a: enterprise user
- On page:
/admin/orders/XXXX/edit
- I want to be able to do:
On the Admin/orders page, a hub manager should be able to see all the costs on an order, and the details on this page should add up to the order total
At present, taxes on fees (when applicable) are not included in the line item adjustment table on the admin/orders page - and users cannot understand why they cannot arrive at the order total from the information presented to them on this page. This prompts a request from most new users telling us that their orders are calculating incorrectly.
Example
This shop has a 20% enterprise fee on all products.
This fee is set to 'taxable' (but same result if it is set to 'inherit from product'
They sell a taxable product - candles ($10)
I purchase 1 candle and the costs should be:
Product - $10
Tax on product (13% x $10) = $1.30
Fee on product (20% x %10) = $2.00
Fee on product tax (13% x $2.00) = $0.26
Order total is $13.56, Including tax of $1.56
See below that the confirmation at checkout to the customer is correct, and the invoice is correct...
But see that the hub manager is confused because they do not arrive at the order total if they add up the product + line items on the admin/orders page.
Acceptance Criteria & Tests
The text was updated successfully, but these errors were encountered: