Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unused OFN Enterprise fields #11243

Closed
kirstenalarsen opened this issue Jul 20, 2023 · 4 comments · Fixed by #12460
Closed

Clean up unused OFN Enterprise fields #11243

kirstenalarsen opened this issue Jul 20, 2023 · 4 comments · Fixed by #12460
Assignees
@mkllnk
Milestone
[API] Discovery E...

Comments

@kirstenalarsen
Copy link
Contributor

kirstenalarsen commented Jul 20, 2023 •
edited

During inception / analysis I am noting fields on the Enterprise table in OFN that I think are obsolete and unused (I don't even know where you could update them in the UI?). Noting here as potential papercut to remove

  • Pickup Times
  • Next Collection At
  • Distributor Info
@kirstenalarsen
Copy link
Contributor Author

@mkllnk searched the code and found
I searched the code:
pickup_times: unused.
next_collection_at: used as backup value if the order cycle doesn't have a pickup_time defined for a distributor.
distributor_info: unused.

So let's delete pickup_times and distributor_info only

@kirstenalarsen
Copy link
Contributor Author

@rioug might as well just knock this off and get it out of the way

@RachL RachL added this to the [API] Discovery Endpoints milestone Feb 28, 2024
@mkllnk mkllnk assigned mkllnk and unassigned rioug May 10, 2024
@mkllnk
Copy link
Member

mkllnk commented May 10, 2024

I just stumbled across this and thought I better clean it up.

@mkllnk mkllnk mentioned this issue May 10, 2024
Merged
4 tasks
@kirstenalarsen
Copy link
Contributor Author

Thank you. Please ensure it is tracked against macdoch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkllnk mkllnk

Labels
None yet
Projects
Discover Regenerative
Status: Done
OFN Delivery board
Status: Done
Milestone
[API] Discovery Endpoints
Development

Successfully merging a pull request may close this issue.

Clean up unused enterprise fields mkllnk/openfoodnetwork
4 participants
@kirstenalarsen @mkllnk @RachL @rioug