Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connected App is connecting twice #12471

Closed
mkllnk opened this issue May 14, 2024 · 2 comments · Fixed by #12481
Closed

Connected App is connecting twice #12471

mkllnk opened this issue May 14, 2024 · 2 comments · Fixed by #12481
Assignees
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround.

Comments

@mkllnk
Copy link
Member

mkllnk commented May 14, 2024

ℹ️ Please use project Discover Regenerative (Macdoch pt 2): 3. Open Source Tech Evolution to track work on this issue.

Description

Some people manage to click the button to connect the Discover Regenerative app twice. It then creates two Connected App records and triggers two webhooks which can create two entries in the portal database.

I think that this happens when the server is busy or the connection is slow. The button is turned into a disabled "Loading" button with a delay and that delay can be longer when the server is busy, allowing for multiple clicks.

We should disable the button after clicking straight away.

Expected Behavior

You can click the button only once.

Actual Behaviour

You can click the button multiple times. The slower the server responds, the more often you can click it.

Steps to Reproduce

  1. Turn on feature for connected apps.
  2. Go to enterprise settings and connected apps.
  3. Click on the connect button many times as fast as possible.
  4. Check the webhook executions in n8n.

Animated Gif/Screenshot

Workaround

Severity

Your Environment

  • Version used:
  • Browser name and version:
  • Operating System and version (desktop or mobile):

Possible Fix

  • Add JS to disable button.
  • Replace StimulusReflex with Turbo.
@mkllnk mkllnk added the bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. label May 14, 2024
@mkllnk mkllnk self-assigned this May 14, 2024
@kirstenalarsen
Copy link
Contributor

@mkllnk please connect clockify code to this issue

@mkllnk
Copy link
Member Author

mkllnk commented May 15, 2024

Okay, tracking under Discover Regenerative (Macdoch pt 2): 3. Open Source Tech Evolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants