Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataGrid / DataList - enableSorting enable by default #320

Open
jbpenrath opened this issue Apr 29, 2024 · 0 comments
Open

DataGrid / DataList - enableSorting enable by default #320

jbpenrath opened this issue Apr 29, 2024 · 0 comments
Labels
question Further information is requested

Comments

@jbpenrath
Copy link
Member

On DataGrid / DataList components, the sorting is enabled by default. But if this prop is true but no sortModel is provided a warning is raised.

Should we disable enableSorting by default ?

e.g: Warning raised during tests

stderr | src/components/DataGrid/index.spec.tsx > <DataGrid/> > should render custom cells
You are using a column with sorting enabled, but you are not providing an `onSortModelChange` handler. The sorting will not work as expected.
You are using a column with sorting enabled, but you are not providing an `onSortModelChange` handler. The sorting will not work as expected.
You are using a column with sorting enabled, but you are not providing an `onSortModelChange` handler. The sorting will not work as expected.
You are using a column with sorting enabled, but you are not providing an `onSortModelChange` handler. The sorting will not work as expected.
@jbpenrath jbpenrath added the question Further information is requested label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant