Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2123 refactor baselayoutheader #2137

Closed
wants to merge 0 commits into from

Conversation

disKeith
Copy link
Contributor

Problem

Public and private NavBar headers were collectively stored in one object array, messy and has redundant properties.

Closes [#2123]

Solution

Refactored code to check for client's login state before performing the respective logic:

  • Populating the header object and properties
  • Populating the button & header attributes
  • Collapsed login button code within the same code block

@disKeith disKeith linked an issue Dec 16, 2022 that may be closed by this pull request
@disKeith disKeith closed this Jan 4, 2023
@disKeith disKeith force-pushed the 2123-refactor-baselayoutheader branch from d64e050 to 49e0cee Compare January 4, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor BaseLayoutHeader
1 participant