Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed duplicate status descriptions #126

Closed
wants to merge 1 commit into from
Closed

removed duplicate status descriptions #126

wants to merge 1 commit into from

Conversation

tulshi
Copy link
Contributor

@tulshi tulshi commented Oct 3, 2023

No description provided.

@tulshi tulshi linked an issue Oct 3, 2023 that may be closed by this pull request
Copy link
Contributor

@FragLegs FragLegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes any description of what the enabled, paused, and disabled states mean. I think we need to at least describe the expected behavior for the Transmitter in each state.

@tulshi
Copy link
Contributor Author

tulshi commented Oct 3, 2023

This change removes any description of what the enabled, paused, and disabled states mean. I think we need to at least describe the expected behavior for the Transmitter in each state.

Do the descriptions in 7.1.2 suffice to describe each state?

@FragLegs
Copy link
Contributor

FragLegs commented Oct 3, 2023

7.1.2 only talks about what the Transmitter should do if it decides to change the stream status without the Receiver's input. It doesn't describe at all what the states mean or what the Transmitter is expected to do in each state.

@tulshi tulshi closed this Oct 4, 2023
@tulshi
Copy link
Contributor Author

tulshi commented Oct 4, 2023

PR incorrectly removes text that is required in the spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicit event retention policy in event stream metadata
2 participants