Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected Response When Polling After Stream Delete #128

Closed
independentid opened this issue Oct 5, 2023 · 2 comments · Fixed by #177
Closed

Expected Response When Polling After Stream Delete #128

independentid opened this issue Oct 5, 2023 · 2 comments · Fixed by #177
Labels
bug Something isn't working spec:SSF v3 Address this issue before the v3 cutoff (June 15, 2024)

Comments

@independentid
Copy link

If a transmitter polling stream is "deleted" before the receiving entity "shuts down", it is unclear what should happen at the polling endpoint. How graceful should the shut down be?

Note: I see notation that Paused or Disabled event should send a Stream-updated-event upong being re-enable, but no mention is made of sending event when changing state to pause or disabled.

If a stream is disabled or deleted it would be useful for a period of time for the polling endpoint to indicate in the polling response that the Stream is disabled or deleted (e.g. include status response attributes). This allows the poller to download remaining events, detect the change and exit gracefully.

Eventually after all events are gone, specify status 404 is to be returned. Or specify status 410 Gone to indicate the stream has been removed (though the url was valid).

@tulshi tulshi added documentation Improvements or additions to documentation spec:SSF labels Apr 20, 2024
@FragLegs
Copy link
Contributor

FragLegs commented May 9, 2024

It may have been added since this issue was created, but the spec does say that the Transmitter MUST emit a Stream Updated event when going from enabled to paused/disabled as well as when going from paused/disabled to enabled. We don't currently model the idea of a deleted stream, but we could add a recommendation that if the Transmitter is going to delete a stream, they disable it first with a reason explaining that deletion is imminent.

@FragLegs FragLegs added the v3 Address this issue before the v3 cutoff (June 15, 2024) label May 9, 2024
@FragLegs
Copy link
Contributor

FragLegs commented May 9, 2024

Actually, there appears to be conflicting language in the spec. In section 7.1.2 it says the Transmitter SHOULD/MAY send a Stream Updated event when going from paused/disabled to enabled (respectively). But in section 7.1.5, it says MUST. We should update 7.1.2 to also say MUST.

@FragLegs FragLegs added bug Something isn't working and removed documentation Improvements or additions to documentation labels May 9, 2024
@FragLegs FragLegs linked a pull request May 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spec:SSF v3 Address this issue before the v3 cutoff (June 15, 2024)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants