Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Optimizing BroadcastJob Performance #1593

Open
zmberg opened this issue Apr 25, 2024 · 2 comments
Open

[feature request] Optimizing BroadcastJob Performance #1593

zmberg opened this issue Apr 25, 2024 · 2 comments
Assignees
Milestone

Comments

@zmberg
Copy link
Member

zmberg commented Apr 25, 2024

What would you like to be added:
BroadcastJob Controller list pods need add the disableDeepCopy options to improve performance in large-scale clusters. refer code: https://github.com/openkruise/kruise/blob/master/pkg/controller/broadcastjob/broadcastjob_controller.go#L216. For examples:

err = r.List(context.TODO(), podList, listOptions, utilclient.DisableDeepCopy)
	if err != nil {
		klog.Errorf("failed to get podList for job %s,", job.Name)
		return reconcile.Result{}, err
	}

Why is this needed:

@manan1979
Copy link

can i work on this issue ?

@zmberg
Copy link
Member Author

zmberg commented Apr 25, 2024

/assign @manan1979

@zmberg zmberg added this to the 1.7 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants