Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No default export #1094

Open
Christoph142 opened this issue Aug 28, 2023 · 6 comments
Open

No default export #1094

Christoph142 opened this issue Aug 28, 2023 · 6 comments
Assignees
Labels
bug to_discuss To discuss during next community meeting

Comments

@Christoph142
Copy link

I used to use
import OLCesium from 'ol-cesium';
This works fine in 2.15.0, but in 2.15.1 and 2.15.2 angular complains that there's no default export.

Am I doing something wrong? Is the import supposed to be done differently or did something break?

@gberaudo
Copy link
Member

Hi @Christoph142 , I can reproduce your import error with plain javascript.
We are planning to rework the build system and publish only standard ES6 modules.
In the meantime could you stay with 2.15.0?

@gberaudo gberaudo added bug to_discuss To discuss during next community meeting labels Aug 29, 2023
@gberaudo gberaudo self-assigned this Aug 29, 2023
@Christoph142
Copy link
Author

Thanks for checking this out. I already pinned down 2.15.0 for the time being and I'm keeping an eye on this here.

@gberaudo
Copy link
Member

See #1096.

@ccondrup
Copy link

ccondrup commented Sep 7, 2023

ES6 modules, exported types and updated build system sounds great!

@Christoph142 could you please share a working usage example on Stackblitz or similar? Would love to see your package.json and how you import and use ol-cesium 2.15.x in Angular. I have had to pin olcs 2.14.0 and cesium 1.105.2 since newer versions of either yields various errors (related to layers, overlays and vector-projections) from the Angular component that toggles 2D/3D-map. Sorry for hijacking thread, I'm asking for sort of the same end result though.

@Christoph142
Copy link
Author

@ccondrup the trick is installing ol-cesium npm package.
olcs doesn't work.

@levinzz
Copy link

levinzz commented Nov 9, 2023

I bumped into the same issue and tried going with 2.15.0 to no avail :

./node_modules/cesium/Source/Cesium.js:795:0-62 - Error: export 'parseBoundingVolumeSemantics' (reexported as 'parseBoundingVolumeSemantics') was not found in '@cesium/engine' (possible exports: AlphaMode, AlphaPipelineStage, Appearance, ApproximateTerrainHeights, [...], updateVersion, usesExtension, webGLConstantToGlslType, wrapFunction, writeTextToCanvas)

I also tried setting up a stackblitz in order to reproduce the issue but it runs into another compile issue (just uncomment line 12 in main.ts for it to occur) :

Error in /turbo_modules/cesium@1.107.0/index.cjs (10:18) Module /turbo_modules/cesium@1.107.0/Build/CesiumUnminified/index.cjs not declared as a System.registerDynamic dependency of https://angular-14-demo-pjm6dp.stackblitz.io/turbo_modules/cesium@1.107.0/index.cjs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug to_discuss To discuss during next community meeting
Projects
None yet
Development

No branches or pull requests

4 participants