Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade to mocha@2.3.4 #4746

Merged
merged 1 commit into from Jan 27, 2016
Merged

Downgrade to mocha@2.3.4 #4746

merged 1 commit into from Jan 27, 2016

Conversation

tschaub
Copy link
Member

@tschaub tschaub commented Jan 27, 2016

See #4726 (comment).

Also related:

And more upgrade hazards:

Before upgrading mocha, let's confirm npm test works locally and that the output is readable on Travis.

@tschaub
Copy link
Member Author

tschaub commented Jan 27, 2016

Before:

image

After:

image

@marcjansen
Copy link
Member

This looks good to me, thanks and please merge!

tschaub added a commit that referenced this pull request Jan 27, 2016
@tschaub tschaub merged commit 474fd8d into openlayers:master Jan 27, 2016
@tschaub tschaub deleted the roll-back-mocha branch January 27, 2016 22:41
@boneskull
Copy link

@tschaub @marcjansen et al

Please see this build with the proposed fix, and the summary of changes.

If everything looks good, I will merge and release this so you guys can get back on track with new versions.

@marcjansen
Copy link
Member

Thanks for pinging us, @boneskull. We'll definitely check this.

@tschaub
Copy link
Member Author

tschaub commented Jan 28, 2016

Thanks @boneskull. Here's a build in progress: https://travis-ci.org/openlayers/ol3/builds/105522588

All looks good locally. Thanks for the work on this, and for reaching out about the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants