Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipped VectorTile rendering with renderMode: 'image' when browser is zoomed #10553

Closed
mshubin opened this issue Jan 20, 2020 · 11 comments · Fixed by #10982
Closed

Clipped VectorTile rendering with renderMode: 'image' when browser is zoomed #10553

mshubin opened this issue Jan 20, 2020 · 11 comments · Fixed by #10982

Comments

@mshubin
Copy link

mshubin commented Jan 20, 2020

Describe the bug
I have a similar issue which has been raised here but this time with VectorTile using renderMode: 'image'.

When user zoomed the browser (with Ctrl-+ for example) it makes tiles clipped as in animation below:
clipped-tiles
.. there is a some kind of 'clip' between tiles.

The bug doesn't occur when:

  • Browser is 100%
  • imageMode is 'hybrid'

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://codesandbox.io/s/clipped-mvt-rendering-with-browser-zoom-ecocl?fontsize=14&hidenavigation=1&theme=dark
  2. Zoom your browser (I reproduced with 150%)
  3. Reload the url (otherwise it will work)
  4. Zoom to left from 'Juranville' city
  5. On level 19 you'll see the output as in animation

Expected behavior
The rendering as when the browser is not zoomed.

Thank you in advance and have a nice day,

@stale
Copy link

stale bot commented Mar 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 20, 2020
@jeroenvheel
Copy link

I also have the same problem !! I’m going to turn off image rendering tomorrow and see if it’s working.

@stale stale bot removed the stale label Mar 23, 2020
@jeroenvheel
Copy link

When using Image / hybrid or vector i still git the clipped vector

image

@jeroenvheel
Copy link

I fixed this by adding a bigger buffer to the tile vector

@Benjaki2
Copy link
Contributor

I am having this problem as well.

@ahocevar
Copy link
Member

ahocevar commented Apr 24, 2020

The screenshot that @jeroenvheel looks like the vector tile source might have polygons with the wrong winding order. That could be fixed by configuring the MVT format with ol/Feature as featureClass:

import VectorTileSource from 'ol/source/VectorTile';
import MVT from 'ol/format/MVT';
import Feature from 'ol/Feature';

new VectorTileSource({
  format: new MVT({
    featureClass: Feature
  }),
})

@Benjaki2
Copy link
Contributor

Here are some examples:

OL-latest
ol-point

OL5.3.0
ol5-point

Code example
https://codepen.io/benjaki/pen/zYvzGxd

@ahocevar
Copy link
Member

ahocevar commented Apr 29, 2020

@Benjaki2 Your issue is caused by an invalid tilegrid. Probably due to #10974. Thanks for the test case, that should help to isolate the issue.

@ahocevar
Copy link
Member

ahocevar commented Apr 29, 2020

@Benjaki2 Your issue is fixed with #10982

@mshubin's issue looks similar, so I think that should also be fixed. Can you please test with the fix applied and report back?

@mshubin
Copy link
Author

mshubin commented May 7, 2020

@ahocevar I confirm, I've tested it in my codesandbox example with last 6.3.2-dev and the issue doesn't occur anymore 👍 Can't wait to integrate it in our app.

Thank you very much !

@Benjaki2
Copy link
Contributor

Benjaki2 commented May 7, 2020

Looks great. Thank you! @ahocevar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants