Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you please add support to decompress to ZipOutputStream ? #15

Open
kiwi1969 opened this issue Mar 12, 2024 · 6 comments
Open

Can you please add support to decompress to ZipOutputStream ? #15

kiwi1969 opened this issue Mar 12, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@kiwi1969
Copy link

It would be great if we had option to output a compressed zip file instead of a huge SMF file.
Then people that process the data using Java can read using ZipInputStream

@kiwi1969 kiwi1969 changed the title Can you please add support to decompress using ZipOutputStream ? Can you please add support to decompress to ZipOutputStream ? Mar 12, 2024
@alexgubanow
Copy link

hi, yes it can be done and does make sense as the output files sometimes are huge. Feel free to suggest a change :) i see it can be done in TerseDecompresser

@kiwi1969
Copy link
Author

I have submitted a pull request to output via GZIPOutputStream is the filename is specified with ".gz"
This results in a much smaller file than the Terse was (about 50% size), which is also usable by programs that use GZIPInputStream to read the file.

@alexgubanow alexgubanow added the enhancement New feature or request label Mar 27, 2024
@kiwi1969
Copy link
Author

Created code that uses GZIPOutputStream
I have been told to create a branch from this issue - how is this done ?

@alexgubanow
Copy link

image
not sure if you have such a button. I believe it will be enough if name of branch starts with a issue number, like :
15-can-you-please-add-support-to-decompress-to-zipoutputstream
In same time, please base your changes on "release-5.0.1" branch, because that already has fixes to pom.xml and it is a branch where we collect all fixes, before merging to master.

@kiwi1969
Copy link
Author

I rebased my code by merging into it the changes made in 5.0.1.
Note that I use maven shade in my pom.xml, where 5.0.1 wasn't.
I also added some symbolics and default to Java 17.
I dunno which pom.xml you prefer (mine vs 5.0.1)

@alexgubanow
Copy link

sorry for a delay, added comments to PR, as well changed the target branch to be release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants