Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for verifying User Attributes in verifyAllUsers #1637

Merged
merged 8 commits into from May 15, 2023
Merged

Add support for verifying User Attributes in verifyAllUsers #1637

merged 8 commits into from May 15, 2023

Conversation

martgil
Copy link
Contributor

@martgil martgil commented Apr 27, 2023 •
edited by twiss

This PR adds support for verifying user attributes in verifyAllUsers().

Fixes #1636.

@martgil martgil mentioned this pull request Apr 27, 2023
Closed
twiss
twiss reviewed Apr 27, 2023
View reviewed changes
Copy link
Member

@twiss twiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making a PR! See comments below.

src/key/key.js Outdated Show resolved Hide resolved
src/key/key.js Outdated Show resolved Hide resolved
@martgil martgil marked this pull request as draft April 28, 2023 02:31
@martgil martgil marked this pull request as ready for review April 28, 2023 02:54
@martgil martgil requested a review from twiss April 28, 2023 02:57
twiss
twiss reviewed Apr 30, 2023
View reviewed changes
Copy link
Member

@twiss twiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test case! Some nit picks and further suggestions below.

test/general/key.js Outdated Show resolved Hide resolved
test/general/key.js Outdated Show resolved Hide resolved
test/general/key.js Outdated Show resolved Hide resolved
test/general/key.js Outdated Show resolved Hide resolved
@martgil martgil requested a review from twiss May 1, 2023 04:39
twiss
twiss reviewed May 1, 2023
View reviewed changes
test/general/key.js Outdated Show resolved Hide resolved
@martgil martgil requested a review from twiss May 3, 2023 02:36
@ioanmo226 ioanmo226 mentioned this pull request May 10, 2023
Closed
@ioanmo226
Copy link

@twiss, do you have an ETA for when this pull request will be available on npm?

@twiss twiss changed the title issue #1636 add userID checking on verifyAllUsers() Add support for verifying User Attributes in verifyAllUsers May 15, 2023
@twiss twiss force-pushed the issue-1636-add-user-id-checks-in-verifyallusers branch from fa7159f to ada3057 Compare May 15, 2023 12:37
@twiss twiss merged commit 29d2b70 into openpgpjs:main May 15, 2023
24 checks passed
@twiss
Copy link
Member

twiss commented May 15, 2023

We've released v5.9.0 with this change 🙂

@ioanmo226
Copy link

Thank you @twiss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioanmo226 ioanmo226 ioanmo226 left review comments

@twiss twiss twiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

verifyAllUsers() returns userID error for keys that contains image data
3 participants
@martgil @ioanmo226 @twiss