Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DeathAdder V3 Pro (00c2/00c3) #2239

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ryan-1337
Copy link

@ryan-1337 ryan-1337 commented Apr 27, 2024

Fixes #2214

@z3ntu z3ntu changed the title add support for deathadder v3 pro 2024 Add support for DeathAdder V3 Pro (00c2/00c3) Apr 28, 2024
@z3ntu
Copy link
Member

z3ntu commented Apr 28, 2024

Does any marketing material / names actually include "2024" in the name? If not please remove that from the name here, we already have several of such instances with other devices.

Also could you share here again what the status of this is? You wrote before "it's not detected by polychromatic" but do for example the udev rules trigger, the kernel driver bind, etc?

@ryan-1337
Copy link
Author

Can we rename the device to Deathadder v3 pro Smooth as described on the razer website instead of deathadder v3 pro 2024?

On my machine I can't load the drivers but on a vm everything loads fine.

@z3ntu
Copy link
Member

z3ntu commented Apr 28, 2024

I don't see the device being named that way? Sure, you can select "Smooth-Touch" as finish but it's not a part of the device name, and the "Classic Base" surely would be the same software-wise.

image

So I think just "DeathAdder V3 Pro" like the device that's already supported is fine. I think other devices with the same "problem" use e.g. _ALT in the driver (Ornata V3 X)

@z3ntu
Copy link
Member

z3ntu commented May 9, 2024

Why did you rename the device after I wrote #2239 (comment) ?

@ryan-1337
Copy link
Author

Why did you rename the device after I wrote #2239 (comment) ?

Sorry, I didn't quite understand.
it's fixed


DPI_MAX = 30000

POLL_RATES = [125, 500, 1000]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't support 8000 Hz polling rate when wired? Only wireless?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes 8k wireless only

@z3ntu
Copy link
Member

z3ntu commented May 9, 2024

So functionality-wise everything works correctly? Any functionality missing?

@ryan-1337
Copy link
Author

So functionality-wise everything works correctly? Any functionality missing?

yes, everything looks good to me

@ryan-1337 ryan-1337 requested a review from z3ntu May 17, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Support for DeathAdder V3 Pro (2024)
2 participants