Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring batch migration should remove extends DefaultBatchConfigurer #412

Closed
sambsnyd opened this issue Aug 9, 2023 · 0 comments · Fixed by #417
Closed

Spring batch migration should remove extends DefaultBatchConfigurer #412

sambsnyd opened this issue Aug 9, 2023 · 0 comments · Fixed by #417
Assignees
@timtebeek
Labels
enhancement New feature or request

Comments

@sambsnyd
Copy link
Member

sambsnyd commented Aug 9, 2023 •
edited

The DefaultBatchConfigurer class has been removed with no replacement. That extends clause should be removed.

Remove and remove any @Override methods from that class, and remove the methods if the body is empty. If the body is not empty remove the @Override and leave a comment.

Also see:
@sambsnyd sambsnyd added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Aug 9, 2023
@timtebeek timtebeek self-assigned this Aug 9, 2023
timtebeek added a commit that referenced this issue Aug 14, 2023
@timtebeek
Remove DefaultBatchConfigurer
27d3409 
Fixes #412
@timtebeek timtebeek mentioned this issue Aug 14, 2023
Merged
timtebeek added a commit that referenced this issue Aug 15, 2023
@timtebeek
Remove DefaultBatchConfigurer (#417)
937bdf9 
* Remove DefaultBatchConfigurer

Fixes #412

* Add license

* Use Markup.info

* Only remove methods from DefaultBatchConfigurer

* Strip calls to super()

* Remove Bean-like usage in new DefaultBatchConfigurer(dataSource)

* Add recipe to spring batch migrations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timtebeek timtebeek

Labels
enhancement New feature or request
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove DefaultBatchConfigurer openrewrite/rewrite-spring
2 participants
@timtebeek @sambsnyd