Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement][opensearch] support appProtocol in service declaration for https communication as a gateway backend #751

Open
dhardy92 opened this issue Mar 7, 2024 · 1 comment
Open

[Enhancement][opensearch] support appProtocol in service declaration for https communication as a gateway backend #751

dhardy92 opened this issue Mar 7, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dhardy92
Copy link

dhardy92 commented Mar 7, 2024

Hello,
In our GKE cluster, we would use Kubernetes Gateway to expose Opensearch service on VPC as described in https://cloud.google.com/kubernetes-engine/docs/how-to/secure-gateway#load-balancer-tls

Add a possibility via operator file to specify spec.port[].appProtocol: https in opensearch service

Acording to https://pkg.go.dev/k8s.io/api/core/v1#ServicePort, this would be possible adding AppProtocol: "https" in block

opensearch-k8s-operator/opensearch-operator/pkg/builders/cluster.go

Lines 651 to 657 in 0494837

{
Name: "http",
Protocol: "TCP",
Port: cr.Spec.General.HttpPort,
TargetPort: intstr.IntOrString{
IntVal: cr.Spec.General.HttpPort,
},

Thank you
@dhardy92 dhardy92 added enhancement New feature or request untriaged Issues that have not yet been triaged labels Mar 7, 2024
@salyh salyh removed the untriaged Issues that have not yet been triaged label Mar 28, 2024
@salyh
Copy link
Collaborator

salyh commented Mar 28, 2024

This would absolutely make sense. Thank you for your contribution.

@dhardy92 Do you want to open a PR for that?

@salyh salyh added the good first issue Good for newcomers label Mar 28, 2024
dhardy92 pushed a commit to dhardy92/opensearch-k8s-operator that referenced this issue Mar 28, 2024
solve opensearch-project#751 by adding `spec.port.0.appProtocol: "HTT…
4e3c03c 
…PS"` for compliance with GKE gateways

Signed-off-by: dhardy <dhardy@figarocms.fr>
dhardy92 pushed a commit to dhardy92/opensearch-k8s-operator that referenced this issue Mar 28, 2024
solve opensearch-project#751 by adding `spec.port.0.appProtocol: "HTT…
ab99853 
…PS"` for compliance with GKE gateways

Signed-off-by: dhardy <dhardy@figarocms.fr>
@dhardy92 dhardy92 mentioned this issue Mar 28, 2024
Open
dhardy92 pushed a commit to dhardy92/opensearch-k8s-operator that referenced this issue Mar 28, 2024
solve opensearch-project#751 : fix build "cannot use "HTTPS" (untyped…
27869ee 
… string constant) as *string value in struct literal

Signed-off-by: dhardy <dhardy@figarocms.fr>
dhardy92 pushed a commit to dhardy92/opensearch-k8s-operator that referenced this issue Mar 29, 2024
solve opensearch-project#751 : use corev1.URISchemeHTTPS const as "HT…
0ce2288 
…TPS"

Signed-off-by: dhardy <dhardy@figarocms.fr>
dhardy92 pushed a commit to dhardy92/opensearch-k8s-operator that referenced this issue Mar 29, 2024
solve opensearch-project#751 : variable is required because AppProtoc…
73c3db9 
…ol is *string

Signed-off-by: dhardy <dhardy@figarocms.fr>
dhardy92 pushed a commit to dhardy92/opensearch-k8s-operator that referenced this issue Apr 2, 2024
Add Service appProtocol for GKE Gateway support as backend (opensearc…
364ac09 
…h-project#751)

### Description
Adding `spec.port.0.appProtocol: "HTTPS"` for compliance with GKE gateways
cf : https://cloud.google.com/kubernetes-engine/docs/how-to/secure-gateway#load-balancer-tls

### Issues Resolved
Fixes opensearch-project#751

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Damien HARDY <dhardy@figarocms.fr>
dhardy92 pushed a commit to dhardy92/opensearch-k8s-operator that referenced this issue Apr 2, 2024
Add Service appProtocol for GKE Gateway support as backend (opensearc…
c63e628 
…h-project#751)

### Description
Adding `spec.port.0.appProtocol: "HTTPS"` for compliance with GKE gateways
cf : https://cloud.google.com/kubernetes-engine/docs/how-to/secure-gateway#load-balancer-tls

### Issues Resolved
Fixes opensearch-project#751

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Damien HARDY <dhardy@figarocms.fr>
Signed-off-by: dhardy <dhardy@figarocms.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhardy92 @salyh