Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match .browserlist with OpenSearch Dashboards #1023

Open
gulderov opened this issue Sep 6, 2023 · 3 comments · May be fixed by #1104
Open

Match .browserlist with OpenSearch Dashboards #1023

gulderov opened this issue Sep 6, 2023 · 3 comments · May be fixed by #1104
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gulderov
Copy link
Contributor

gulderov commented Sep 6, 2023

.browserlist could be merged with OpenSearch Dashboards version

Please check opensearch-project/OpenSearch-Dashboards#4649 for motivation and description

@BSFishy BSFishy added enhancement New feature or request good first issue Good for newcomers and removed untriaged labels Sep 7, 2023
@ShatilKhan
Copy link
Contributor

Hey @gulderov , @BSFishy
I may be able to work on this, can you provide some additional info / steps on how to achieve this?

@BSFishy
Copy link
Contributor

BSFishy commented Oct 12, 2023

I may be able to work on this, can you provide some additional info / steps on how to achieve this?

Essentially, the browserslist is a list of browsers we want to support. It is mainly phrases like "last 2 versions of [browser name]" or "not [browser name]", which allows us to get an up to date matrix of browsers we support at any given time. Our build system then uses this browser matrix and a list of features each one supports to inject "polyfills", or implementations of new features for old targets.

More documentation on browserslists can be found on their Github repo: https://github.com/browserslist/browserslist#browserslist-

Essentially, this task is to just make OUI's browserslist match OSD's, which was updated here: opensearch-project/OpenSearch-Dashboards#4649

Simply make OUI's browserslist match OSD's production list.

@ShatilKhan ShatilKhan linked a pull request Oct 18, 2023 that will close this issue
7 tasks
@ShatilKhan
Copy link
Contributor

Thank you so much for the guidance @BSFishy !
I've raised my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants