Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Building process breaks when path has space #1131

Open
BigSamu opened this issue Oct 31, 2023 · 2 comments · May be fixed by #1156
Open

[BUG] Building process breaks when path has space #1131

BigSamu opened this issue Oct 31, 2023 · 2 comments · May be fixed by #1156
Assignees
@willie-hung
Labels
bug Something isn't working

Comments

@BigSamu
Copy link
Contributor

BigSamu commented Oct 31, 2023 •
edited

Describe the bug

When running yarn build for oui, the build fails if the path to the folder has an empty space.

To Reproduce
Steps to reproduce the behavior:

  1. Clone the repo using the following command: git clone git clone https://github.com/opensearch-project/oui.git bug_oui\ space
  2. Run yarn install
  3. Run yarn build
  4. See error

Expected behavior

The build process should not cause this error. It should manage path with blank spaces.

Screenshots

Error screenshot

image

Host/Environment (please complete the following information):

  • OUI Version: Latest version in development
  • OS: macOS Ventura 13.5.2

Additional context

N/A
@BigSamu BigSamu added bug Something isn't working untriaged labels Oct 31, 2023
@BSFishy BSFishy removed the untriaged label Oct 31, 2023
@BSFishy BSFishy changed the title [BUG] Building process break when path us empty space [BUG] Building process breaks when path has space Oct 31, 2023
@BSFishy
Copy link
Contributor

BSFishy commented Oct 31, 2023

I've noticed most people have issues when the space is further up in their path. For example one might create a My Projects directory, into which they clone OUI. Even in that case, where the path is ~/My Projects/oui, this issue persists.

@willie-hung
Copy link
Contributor

I would like to pick up this one:)

@willie-hung willie-hung linked a pull request Nov 15, 2023 that will close this issue
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willie-hung willie-hung

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] Yarn build fails on paths with spaces willie-hung/oui
3 participants
@BSFishy @BigSamu @willie-hung