Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Theme selector incorrectly focus on first item after selection #1163

Open
willie-hung opened this issue Nov 21, 2023 · 5 comments · May be fixed by #1164
Open

[BUG] Theme selector incorrectly focus on first item after selection #1163

willie-hung opened this issue Nov 21, 2023 · 5 comments · May be fixed by #1164
Assignees
@willie-hung
Labels
bug Something isn't working

Comments

@willie-hung
Copy link
Contributor

Describe the bug

When the theme selector is opened, the focus incorrectly remains on the first menu item.

To Reproduce

Steps to reproduce the behavior:

  1. Click the theme selection popup button
  2. Select any theme other than the first one from the list.

Expected behavior

I think the checkmark icon solely is enough, no need another indicator to highlight the current selection. @opensearch-project/opensearch-ux please help confirm the correct UX~

Screenshots

before.mov
@willie-hung willie-hung added bug Something isn't working untriaged labels Nov 21, 2023
@willie-hung willie-hung linked a pull request Nov 21, 2023 that will close this issue
Open
7 tasks
@BigSamu
Copy link
Contributor

BigSamu commented Nov 28, 2023 •
edited

Hi @joshuarrrr, @BSFishy,

May I take this issue?

@BSFishy
Copy link
Contributor

BSFishy commented Dec 7, 2023

May I take this issue?

It looks like @Willie-The-Lord already took this. I'll assign him to prevent further confusion

@BSFishy BSFishy removed the untriaged label Dec 7, 2023
@BigSamu
Copy link
Contributor

BigSamu commented Dec 7, 2023

Ok! If @Willie-The-Lord did not take this, I am happy to work on it!

Regards,

Samuel

@willie-hung
Copy link
Contributor Author

Hi @BigSamu, here's the PR for this issue, if you have any suggestions, you are welcome to comment and discuss there : )

@BigSamu
Copy link
Contributor

BigSamu commented Dec 8, 2023

Hi @BigSamu, here's the PR for this issue, if you have any suggestions, you are welcome to comment and discuss there : )

Great! Thanks! I see you are still working in the PR. Let me take a review to it during the weekend to come with some suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willie-hung willie-hung

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] Theme selector incorrectly focus on first item after selection willie-hung/oui
3 participants
@BSFishy @BigSamu @willie-hung