Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite initial icon computation without mutable variables #1167

Open
BSFishy opened this issue Dec 5, 2023 · 1 comment · May be fixed by #1186
Open

Rewrite initial icon computation without mutable variables #1167

BSFishy opened this issue Dec 5, 2023 · 1 comment · May be fixed by #1186
Assignees
@ShatilKhan
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@BSFishy
Copy link
Contributor

BSFishy commented Dec 5, 2023

#1137 (comment)

This seems like it could be extracted into a function and use return rather than a mutable variable.
@BSFishy BSFishy added enhancement New feature or request good first issue Good for newcomers labels Dec 5, 2023
@BSFishy BSFishy mentioned this issue Dec 5, 2023
Merged
7 tasks
@BSFishy BSFishy removed the untriaged label Dec 5, 2023
@ShatilKhan
Copy link
Contributor

@BSFishy can I take this one?

@ShatilKhan ShatilKhan linked a pull request Dec 15, 2023 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShatilKhan ShatilKhan

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite InitialIcon computation without mutable variables ShatilKhan/oui
2 participants
@BSFishy @ShatilKhan