Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new components in sidecar that can be reused #1257

Open
raintygao opened this issue Mar 12, 2024 · 2 comments
Open

Add new components in sidecar that can be reused #1257

raintygao opened this issue Mar 12, 2024 · 2 comments
Labels
enhancement New feature or request untriaged

Comments

@raintygao
Copy link

raintygao commented Mar 12, 2024

Is your feature request related to a problem? Please describe.
There is a sidecar implementation in OSD, it includes some components that can be reused. We could support some appropriate components and replace raw implementation with them in OSD once supported.

Sidecar contains some resizable button style already defined in OUI, but resizableButton in OUI is not exported and not easy for plugin to import to use, so we'd better research how to redesign this part.
We have something to be discussed, including which directions are supported, only left and right, or can takeover from the bottom? Is it just a push effect or can it also be covered? Exporting just the button or a resizableFlyout seems more appropriate? These require us to spend time thinking and then let the designer decide.

Describe the solution you'd like
We should do a research on what components in the sidecar should be supported in OUI, including what properties, how to design, etc.

Additional context
Sidecar RFC: opensearch-project/OpenSearch-Dashboards#5620
Sidecar OSD PR: opensearch-project/OpenSearch-Dashboards#5920

@raintygao
Copy link
Author

image
After some research, i think we could separate a new component named resizableButton from resizableContainer, and user could implement custom resizable features through this component.

So there will be no UX changes, only involves some component props updates. Hi @AMoo-Miki do you know the process of OUI update? Could I implement directly or needs to involve somebody to review?

@AMoo-Miki
Copy link
Collaborator

i think we could separate a new component
Could I implement directly

Of course. Please do and raise a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged
Projects
None yet
Development

No branches or pull requests

2 participants