Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace clipHAProxyTimeoutValue (firstMatch $timeSpecPattern foo) with clipHAProxyTimeoutValue foo in haproxy-config.template as an optimization. #494

Open
candita opened this issue Jun 23, 2023 · 9 comments
Open

Replace clipHAProxyTimeoutValue (firstMatch $timeSpecPattern foo) with clipHAProxyTimeoutValue foo in haproxy-config.template as an optimization. #494

candita opened this issue Jun 23, 2023 · 9 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@candita
Copy link
Contributor

candita commented Jun 23, 2023 

          BTW, as a follow-up, it might make sense to replace `clipHAProxyTimeoutValue (firstMatch $timeSpecPattern foo)` with `clipHAProxyTimeoutValue foo` in `haproxy-config.template` as an optimization.

Originally posted by @Miciah in #483 (review)
@candita candita mentioned this issue Aug 24, 2023
Merged
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 21, 2023
@candita
Copy link
Contributor Author

candita commented Oct 4, 2023

/remove-lifecycle-stale

@candita
Copy link
Contributor Author

candita commented Oct 4, 2023

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 4, 2023
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2024
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 2, 2024
@candita
Copy link
Contributor Author

candita commented Feb 7, 2024

/remove-lifecycle rotten

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 7, 2024
@candita
Copy link
Contributor Author

candita commented Feb 7, 2024

/remove-lifecycle stale

@rfredette
Copy link
Contributor

This should probably be filed as a maintainability issue, unless there’s a customer with a real-world issue due to the haproxy template taking too long to write.

It would also be useful to have some sort of testing to quantify how long writing the template takes, either as a part of the same issue or as a separate one.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rfredette @openshift-bot @candita