Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PhantomJS for headless browser testing #7697

Closed
quincylvania opened this issue Jun 11, 2020 · 1 comment
Closed

Replace PhantomJS for headless browser testing #7697

quincylvania opened this issue Jun 11, 2020 · 1 comment
Labels
chore-dependency Improvements to one of iD's dependencies

Comments

@quincylvania
Copy link
Collaborator

quincylvania commented Jun 11, 2020

PhantomJS was abandoned in 2018 and the mocha-phantomjs-core project used by iD for testing followed suit. We've been coasting until now, but mocha just deprecated some of the functions used by mocha-phantomjs-core (#7695). This means we can't keep up-to-date with mocha with our current setup, which is an unsustainable proposition. Testing is fundamental.

There's been talk in the past of switching away from PhantomJS, but now it's become a more immediate priority. I'm sure there are good, modern solutions out there, but we need to make sure we're still testing legacy browsers where possible. PhantomJS uses the same polyfills as Internet Explorer and as a result, tests for compatibility issues that might otherwise be difficult to find. See #6087 for related work.

@quincylvania quincylvania added the chore-dependency Improvements to one of iD's dependencies label Jun 11, 2020
@HolgerJeromin
Copy link
Contributor

Can this issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore-dependency Improvements to one of iD's dependencies
Projects
None yet
Development

No branches or pull requests

3 participants