Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCAT TLS connection setup: inconsistent state #10196

Open
EskoDijk opened this issue May 6, 2024 · 0 comments
Open

TCAT TLS connection setup: inconsistent state #10196

EskoDijk opened this issue May 6, 2024 · 0 comments

Comments

@EskoDijk
Copy link
Contributor

EskoDijk commented May 6, 2024

Describe the bug
If a TCAT Commissioner connects via TLS, and the handshake succeeds, but the mTcatAgent.Connected(mTls) setup routine for the TCAT agent fails with an error, then the state becomes inconsistent: the Commissioner thinks it is successfully connected. The TCAT Device has its TLS connection established but TCAT Agent is inactive so won't process any commands.

To Reproduce
(No details given) Connect using a TCAT Commissioner certificate that would fails the checks in Error TcatAgent::Connected(MeshCoP::SecureTransport &aTlsContext) .

  1. Git commit id: ee83d45
  2. IEEE 802.15.4 hardware platform: simulation
  3. Build steps: ./script/cmake-build simulation -DOT_FULL_LOGS=ON
  4. Network topology: single simulated node

Expected behavior
Fate-sharing: if TCAT Device rejects the Commissioner, close the TLS, and send alert to Commissioner. Vice versa if Commissioner rejects the Device, send alert to Device (haven't checked that side yet).

Expect that the return status of this line is used:

            IgnoreReturnValue(mTcatAgent.Connected(mTls));

Console/log output
(TBD) I'll work on a first fix/PR of this issue in order to proceed with the work on TCAT certificates.

Additional context Add any other context about the problem here.
(TBD) I'll work on a first fix/PR of this issue in order to proceed with the work on TCAT certificates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant