Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMF CoAP messages checking for Confirmable/Non-confirmable is too strict #10223

Open
EskoDijk opened this issue May 13, 2024 · 2 comments
Open

Comments

@EskoDijk
Copy link
Contributor

Describe the bug A clear and concise description of what the bug is.

In many places in the Openthread code, checks like below are performed on a received TMF message:

VerifyOrExit(aMessage.IsConfirmablePostRequest());

But in CoAP, the messaging layer (CON/NON) is separated from the request/response processing layer, and therefore the CON or NON transport does not impact the semantics of the request or response. Forcing a particular transport (CON/NON) at the receiver side seems to serve no purpose and also limits the full use of CoAP features in the future.

Please feel free to provide some comments here -- I won't make a PR for this if the basic assumptions are not agreed on, of course.

To Reproduce Information to reproduce the behavior, including:
N/A

Expected behavior A clear and concise description of what you expected to happen.
Only check for required CoAP message elements at the req/resp layer, such as request method (e.g. verify it is POST).

VerifyOrExit(aMessage.IsPostRequest());

Additional context
See RFC 7252

@abtink
Copy link
Member

abtink commented May 14, 2024

@EskoDijk, I agree, makes sense to me to relax the condition if it's permissible for specific commands.

@jwhui
Copy link
Member

jwhui commented May 15, 2024

Relaxing the constraint makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants