Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragile mbedtls configuration #10251

Closed
gilles-peskine-arm opened this issue May 16, 2024 · 1 comment · Fixed by #10263
Closed

Fragile mbedtls configuration #10251

gilles-peskine-arm opened this issue May 16, 2024 · 1 comment · Fixed by #10263
Assignees

Comments

@gilles-peskine-arm
Copy link

third_party/mbedtls/mbedtls-config.h has the following code:

#include "mbedtls/version.h"
// Include in the legacy config name adjustment file for mbedtls >= 3.5.0
#if (MBEDTLS_VERSION_NUMBER >= 0x03050000)
    #include "mbedtls/config_adjust_legacy_crypto.h"
#endif

This is an unintended workaround and might not compile with Mbed TLS 3.6.1. I think that the OpenThread configuration is simple enough that there's currently no problem with inconsistencies, but it's at least fragile.

The solution is to remove this block and also remove #include "mbedtls/check_config.h", which since Mbed TLS 3.0 is done automatically at the right point.

@jwhui
Copy link
Member

jwhui commented May 17, 2024

@gilles-peskine-arm , thanks for raising this issue.

I just submitted #10253. Please review if you get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants